This repository was archived by the owner on May 6, 2020. It is now read-only.
fix(passwd): raise 400 when password is not a parameter#850
Merged
Joshua-Anderson merged 1 commit intodeis:masterfrom Aug 8, 2016
Merged
fix(passwd): raise 400 when password is not a parameter#850Joshua-Anderson merged 1 commit intodeis:masterfrom
Joshua-Anderson merged 1 commit intodeis:masterfrom
Conversation
|
@bacongobbler, @helgi and @mboersma are potential reviewers of this pull request based on my analysis of |
Current coverage is 81.93% (diff: 100%)@@ master #850 diff @@
==========================================
Files 28 28
Lines 3051 3055 +4
Methods 0 0
Messages 0 0
Branches 510 512 +2
==========================================
+ Hits 2499 2503 +4
Misses 404 404
Partials 148 148
|
Contributor
|
Can you rebase? And add some tests |
Joshua-Anderson
force-pushed
the
passwd-fix
branch
from
fd3c632 to
1e13545
Compare
Contributor
Author
|
@helgi Rebased and added some tests. |
Joshua-Anderson
force-pushed
the
passwd-fix
branch
from
1e13545 to
69bee99
Compare
Joshua-Anderson
force-pushed
the
passwd-fix
branch
2 times, most recently
from
37745fb to
32d45c8
Compare
Joshua-Anderson
force-pushed
the
passwd-fix
branch
2 times, most recently
from
6552733 to
7777242
Compare
duanhongyi
pushed a commit
to duanhongyi/workflow
that referenced
this pull request
Dec 4, 2018
Add instructions for DNSmasq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Previously, passwd didn't check if
passwordornew_passwordwas set resulting in server errors when trying to access them.I haven't wrote any tests, cause I wanted to make sure this was the right approach.
I was also looking at serializers, but it doesn't seem like you can override the serializers on a per-view basis. I'm also concerned about using a
DeisException, because I would rather have a field specific error, like serializers do.Testing Instructions
Please provide a detailed list for how to test the changes in this PR.
POST /v2/auth/passwdwithoutnew_passwordorpasswordand make sure 500 errors are returned.